fix(annotations): align firecrawl_search readOnlyHint with scrape tool - #312
Open
syf2211 wants to merge 1 commit into
Open
fix(annotations): align firecrawl_search readOnlyHint with scrape tool#312syf2211 wants to merge 1 commit into
syf2211 wants to merge 1 commit into
Conversation
firecrawl_search accepts scrapeOptions.actions (click/write/executeJavascript) in self-hosted mode but declared readOnlyHint: true, which could let MCP clients skip confirmation prompts incorrectly. Use SAFE_MODE for readOnlyHint so search matches firecrawl_scrape: read-only when cloud/safe mode disables interactive actions, non-read-only otherwise. Fixes firecrawl#311
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set
firecrawl_searchreadOnlyHinttoSAFE_MODEso it matchesfirecrawl_scrapeand reflects whether interactivescrapeOptions.actionsare exposed in the tool schema.Motivation
firecrawl_searchdeclaredreadOnlyHint: truewhile its input schema includesscrapeOptions.actionswithclick,write,press, andexecuteJavascriptin self-hosted mode. MCP clients that honorreadOnlyHintcould skip confirmation prompts for a tool that can drive browser interactions. Reported in #311 via actlintwrite-as-readonly.Changes
src/index.ts:readOnlyHint: true→readOnlyHint: SAFE_MODEonfirecrawl_searchtests/mcp-smoke.test.mjs: assertfirecrawl_searchandfirecrawl_scrapeshare the samereadOnlyHintin stdio (non-cloud) modeTests
npm test— 9/9 pass (build + smoke tests)Notes
CLOUD_SERVICE=true) keepsreadOnlyHint: truebecause interactive actions are omitted from the schema in safe mode.readOnlyHint: false, consistent withfirecrawl_scrape.Fixes #311