Skip to content

fix(storage,windows): dispatch task events on the platform thread - #18667

Open
SelaseKay wants to merge 3 commits into
mainfrom
storage_18664
Open

fix(storage,windows): dispatch task events on the platform thread#18667
SelaseKay wants to merge 3 commits into
mainfrom
storage_18664

Conversation

@SelaseKay

@SelaseKay SelaseKay commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Description

Windows putData progress was posted from a Firebase C++ SDK worker thread. Flutter requires platform-channel messages on the platform thread; concurrent uploads then native-crashed the process.

This PR:

  • Owns the EventSink (the handlers stored a unique_ptr&& member and never took ownership)
  • Posts TaskStateListener / completion events onto the platform thread via an HWND_MESSAGE dispatcher (same approach as Firestore Windows)
  • Keeps the StorageReference that started each upload alive until the SDK Future completes

The concurrent putData e2e (3脳13 overlapping uploads + readback) is expected to go green on Windows after this native change. On the tests-only commit, CI logged the off-thread taskEvent warning and the VM service disappeared as soon as the concurrent test started.

Related Issues

Test plan

  • Windows storage e2e (e2e-storage / windows) passes uploads many small files concurrently and reads them back
  • No sent a message from native to Flutter on a non-platform thread logs on plugins.flutter.io/firebase_storage/taskEvent
  • Android / iOS / macOS / web storage e2e still pass

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Sequential putData tests never overlap progress callbacks, so they miss the native access violation in TaskStateListener::OnProgress.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 馃憤 and 馃憥 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Concurrent putData crashed Windows because progress callbacks called EventSink::Success from an SDK worker thread and the stream handler never owned the sink.
@SelaseKay SelaseKay changed the title test(storage): add concurrent putData e2e for Windows crash fix(storage,windows): dispatch task events on the platform thread Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[firebase_storage] Windows native crash in upload progress callback, sink ownership and thread dispatch

2 participants