Skip to content

fix(cloud_functions): lowercase Android error codes with Locale.ROOT - #18651

Merged
SelaseKay merged 2 commits into
mainfrom
fix/cloud-functions-android-locale-error-codes
Sep 7, 2026
Merged

fix(cloud_functions): lowercase Android error codes with Locale.ROOT#18651
SelaseKay merged 2 commits into
mainfrom
fix/cloud-functions-android-locale-error-codes

Conversation

@SelaseKay

Copy link
Copy Markdown
Contributor

Description

Android maps Cloud Functions error codes with String.lowercase(Locale.getDefault()). On Turkish and Azerbaijani devices, that turns every I into a dotless ı, so documented comparisons such as e.code == 'failed-precondition' fail while codes without i still match.

This switches the mapping to Locale.ROOT (same approach as firebase_auth) and adds a JVM unit test that sets the default locale to tr-TR / az-AZ and asserts the canonical ASCII codes.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Test plan

  • :cloud_functions:testDebugUnitTest passes with Turkish and Azerbaijani default locales
  • Android unit-test workflow runs :cloud_functions:testDebugUnitTest on CI

Turkish and Azerbaijani locales map 'I' to 'ı', so callable codes such as
failed-precondition no longer match the documented ASCII strings.
@SelaseKay SelaseKay added type: bug Something isn't working plugin: functions platform: android Issues / PRs which are specifically for Android. labels Sep 7, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@SelaseKay SelaseKay removed type: bug Something isn't working plugin: functions platform: android Issues / PRs which are specifically for Android. labels Sep 7, 2026
@SelaseKay
SelaseKay merged commit 8f0a5d0 into main Sep 7, 2026
44 of 45 checks passed
@SelaseKay
SelaseKay deleted the fix/cloud-functions-android-locale-error-codes branch September 7, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cloud_functions][android] Error codes are lowercased with the device locale — every code containing "i" breaks on Turkish/Azerbaijani devices

3 participants