ci: bring :app and :e2eTest under the Android Lint gate - #2503
Draft
demolaf wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables Android Lint checks for the :app and :e2eTest modules, integrating them into the root lintAll task and updating the project documentation. It also resolves several lint warnings by extracting hardcoded strings, suppressing specific app link and unused resource warnings, and removing unused assets. The reviewer feedback recommends updating an outdated comment in build.gradle.kts and suggests centralizing the common lint configuration in the root build file to avoid duplication across modules.
demolaf
force-pushed
the
ci/gate-app-and-e2etest-on-lint
branch
from
September 9, 2026 13:56
5b326ae to
c848fb3
Compare
demolaf
force-pushed
the
ci/gate-app-and-e2etest-on-lint
branch
from
September 9, 2026 14:14
c848fb3 to
9da36a1
Compare
demolaf
marked this pull request as draft
September 9, 2026 14:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:appand:e2eTestwere the two modules #2498 left outsidelintAll, since neither declared alint { }block. Both now join the task, which gates all ten.:e2eTestwas already clean;:appreported 30 errors underwarningsAsErrors.SetTextI18n×4 via ademo_score_rowresource,RedundantLabel,UnusedResources×9 (templatecolors.xmland two orphaned launcher vectors),ConvertToWebp(firebase_authto lossless WebP at all five densities, 52KB to 25KB).AppLinkUrlError×2,AppLinksAutoVerify, and thefacebook_*UnusedResources×3 — an App Link host and provider strings that per-module lint cannot resolve.:app, each with its reason in the block:AndroidGradlePluginVersion,LogConditional(same call fix(auth)!: add an Android Lint workflow and gate the Kotlin modules on it #2498 made for:auth),MonochromeLauncherIcon, andKaptUsageInsteadOfKsp— Glide's KSP processor does not generateGlideApp, so that migration means rewriting the storage demo and its README. Following up separately.disableset and the three strictness flags move to a shared policy in the rootbuild.gradle.kts, beside the existingallprojectscheckstyle block — modules keep only their own disables, and strictness is no longer something a module can quietly drop the way:librarydid. 112 lines out, 56 in.lint.yml'sgoogle-services.jsoncomment now names:app, which needs that copy for the same reason:proguard-testsdoes.Supersedes #2500 (branch renamed).
Maintainer note: Fixes internal CPRN-433