Skip to content

ci: bring :app and :e2eTest under the Android Lint gate - #2503

Draft
demolaf wants to merge 1 commit into
ci/run-android-lint-in-the-buildfrom
ci/gate-app-and-e2etest-on-lint
Draft

ci: bring :app and :e2eTest under the Android Lint gate#2503
demolaf wants to merge 1 commit into
ci/run-android-lint-in-the-buildfrom
ci/gate-app-and-e2etest-on-lint

Conversation

@demolaf

@demolaf demolaf commented Sep 9, 2026

Copy link
Copy Markdown
Member

:app and :e2eTest were the two modules #2498 left outside lintAll, since neither declared a lint { } block. Both now join the task, which gates all ten. :e2eTest was already clean; :app reported 30 errors under warningsAsErrors.

  • Fixed: SetTextI18n ×4 via a demo_score_row resource, RedundantLabel, UnusedResources ×9 (template colors.xml and two orphaned launcher vectors), ConvertToWebp (firebase_auth to lossless WebP at all five densities, 52KB to 25KB).
  • Suppressed in place: AppLinkUrlError ×2, AppLinksAutoVerify, and the facebook_* UnusedResources ×3 — an App Link host and provider strings that per-module lint cannot resolve.
  • Disabled for :app, each with its reason in the block: AndroidGradlePluginVersion, LogConditional (same call fix(auth)!: add an Android Lint workflow and gate the Kotlin modules on it #2498 made for :auth), MonochromeLauncherIcon, and KaptUsageInsteadOfKsp — Glide's KSP processor does not generate GlideApp, so that migration means rewriting the storage demo and its README. Following up separately.
  • The common disable set and the three strictness flags move to a shared policy in the root build.gradle.kts, beside the existing allprojects checkstyle block — modules keep only their own disables, and strictness is no longer something a module can quietly drop the way :library did. 112 lines out, 56 in.
  • lint.yml's google-services.json comment now names :app, which needs that copy for the same reason :proguard-tests does.

Supersedes #2500 (branch renamed).


Maintainer note: Fixes internal CPRN-433

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables Android Lint checks for the :app and :e2eTest modules, integrating them into the root lintAll task and updating the project documentation. It also resolves several lint warnings by extracting hardcoded strings, suppressing specific app link and unused resource warnings, and removing unused assets. The reviewer feedback recommends updating an outdated comment in build.gradle.kts and suggests centralizing the common lint configuration in the root build file to avoid duplication across modules.

Comment thread build.gradle.kts
Comment thread app/build.gradle.kts
@demolaf
demolaf force-pushed the ci/gate-app-and-e2etest-on-lint branch from 5b326ae to c848fb3 Compare September 9, 2026 13:56
@demolaf
demolaf force-pushed the ci/gate-app-and-e2etest-on-lint branch from c848fb3 to 9da36a1 Compare September 9, 2026 14:14
@demolaf
demolaf marked this pull request as draft September 9, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant