ci: bring :app and :e2eTest under the Android Lint gate

.github/workflows/lint.yml

@@ -31,8 +31,8 @@ jobs:
           java-version: '21'
           distribution: 'temurin'
 
-      # lintAll gates :proguard-tests, which applies the google-services plugin and
-      # will not configure without this file. Mirrors what scripts/build.sh copies.
+      # lintAll gates :app and :proguard-tests, both of which apply the google-services
+      # plugin and will not configure without this file. Mirrors what build.sh copies.
       - name: Copy google-services.json
         run: |
           cp library/google-services.json app/google-services.json

app/build.gradle.kts

@@ -39,6 +39,38 @@ android {
             }
         }
     }
+
+    lint {
+        // Common lint options across all modules
+        disable += mutableSetOf(
+            "IconExpectedSize",
+            "InvalidPackage", // Firestore uses GRPC which makes lint mad
+            "NewerVersionAvailable", "GradleDependency", // For reproducible builds
+            "SelectableText", "SyntheticAccessor" // We almost never care about this
+        )
+
+        // Module specific
+        disable += mutableSetOf(
+            // Reads the root wrapper, but only the application module analyses it, so it
+            // cannot sit in the common set above. For reproducible builds.
+            "AndroidGradlePluginVersion",
+            // The demos log their auth callbacks unconditionally on purpose — watching
+            // logcat is how you see one fire. Same call as :auth.
+            "LogConditional",
+            // Glide's KSP processor does not generate GlideApp, which the storage demo and
+            // storage/README.md are both written around. Migration tracked separately.
+            "KaptUsageInsteadOfKsp",
+            // A themed icon needs a flat silhouette drawn for the purpose. The only
+            // candidate here is ic_launcher_foreground, whose opaque region is a solid
+            // plate, so it tints to a featureless block — worse than no monochrome layer.
+            "MonochromeLauncherIcon"
+        )
+
+        checkAllWarnings = true
+        warningsAsErrors = true
+        abortOnError = true
+    }
+
     compileOptions {
         sourceCompatibility = JavaVersion.VERSION_17
         targetCompatibility = JavaVersion.VERSION_17

app/src/main/AndroidManifest.xml

@@ -14,15 +14,20 @@
         android:usesCleartextTraffic="true">
         <activity
             android:name="com.firebaseui.android.demo.MainActivity"
-            android:label="@string/app_name"
             android:exported="true"
             android:theme="@style/Theme.FirebaseUIAndroid">
             <intent-filter>
                 <action android:name="android.intent.action.MAIN" />
                 <category android:name="android.intent.category.LAUNCHER" />
             </intent-filter>
 
-            <intent-filter android:autoVerify="true">
+            <!--
+                The host is a placeholder the demo's own Firebase project fills in, so lint
+                can neither read it as a domain nor resolve it over the network.
+            -->
+            <intent-filter
+                android:autoVerify="true"
+                tools:ignore="AppLinkUrlError,AppLinksAutoVerify">
                 <action android:name="android.intent.action.VIEW" />
                 <category android:name="android.intent.category.DEFAULT" />
                 <category android:name="android.intent.category.BROWSABLE" />

app/src/main/java/com/firebaseui/android/demo/database/DatabaseDemoActivity.kt

@@ -33,6 +33,7 @@ import androidx.recyclerview.widget.LinearLayoutManager
 import androidx.recyclerview.widget.RecyclerView
 import com.firebase.ui.database.paging.DatabasePagingOptions
 import com.firebase.ui.database.paging.FirebaseRecyclerPagingAdapter
+import com.firebaseui.android.demo.R
 import com.google.firebase.auth.FirebaseAuth
 import com.google.firebase.database.DatabaseReference
 import com.google.firebase.database.FirebaseDatabase
@@ -122,7 +123,8 @@ class ScoreAdapter(options: DatabasePagingOptions<ScoreItem>) :
     override fun onCreateViewHolder(parent: ViewGroup, viewType: Int) = ScoreViewHolder(parent)
 
     override fun onBindViewHolder(holder: ScoreViewHolder, position: Int, model: ScoreItem) {
-        (holder.itemView as TextView).text = "${model.name}  —  score: ${model.score}"
+        val row = holder.itemView as TextView
+        row.text = row.context.getString(R.string.demo_score_row, model.name, model.score)
     }
 }
 

app/src/main/java/com/firebaseui/android/demo/firestore/FirestoreDemoActivity.kt

@@ -33,6 +33,7 @@ import androidx.recyclerview.widget.LinearLayoutManager
 import androidx.recyclerview.widget.RecyclerView
 import com.firebase.ui.firestore.paging.FirestorePagingAdapter
 import com.firebase.ui.firestore.paging.FirestorePagingOptions
+import com.firebaseui.android.demo.R
 import com.google.firebase.auth.FirebaseAuth
 import com.google.firebase.firestore.CollectionReference
 import com.google.firebase.firestore.FirebaseFirestore
@@ -129,7 +130,8 @@ class ScoreAdapter(options: FirestorePagingOptions<ScoreItem>) :
     override fun onCreateViewHolder(parent: ViewGroup, viewType: Int) = ScoreViewHolder(parent)
 
     override fun onBindViewHolder(holder: ScoreViewHolder, position: Int, model: ScoreItem) {
-        (holder.itemView as TextView).text = "${model.name}  —  score: ${model.score}"
+        val row = holder.itemView as TextView
+        row.text = row.context.getString(R.string.demo_score_row, model.name, model.score)
     }
 }
 

app/src/main/res/values/strings.xml

@@ -1,10 +1,19 @@
-<resources>
+<resources xmlns:tools="http://schemas.android.com/tools">
     <string name="app_name">FirebaseUI Demo</string>
 
     <string name="firebase_web_host" translatable="false">CHANGE-HERE</string>
 
-    <!-- Facebook SDK Configuration -->
-    <string name="facebook_application_id" translatable="false">APP-ID</string>
-    <string name="facebook_login_protocol_scheme" translatable="false">fbAPP-ID</string>
-    <string name="facebook_client_token" translatable="false">CHANGE-HERE</string>
-</resources>
+    <!-- One row of the paging demos: %1$s is the player name, %2$d their score. -->
+    <string name="demo_score_row">%1$s  —  score: %2$d</string>
+
+    <!--
+        The Facebook SDK reads these through the auth module's manifest and provider
+        validation, so lint cannot see them being used from this module.
+    -->
+    <string name="facebook_application_id" translatable="false"
+        tools:ignore="UnusedResources">APP-ID</string>
+    <string name="facebook_login_protocol_scheme" translatable="false"
+        tools:ignore="UnusedResources">fbAPP-ID</string>
+    <string name="facebook_client_token" translatable="false"
+        tools:ignore="UnusedResources">CHANGE-HERE</string>
+</resources>

build.gradle.kts

@@ -40,9 +40,11 @@ tasks.register("lintAll") {
     description = "Runs Android Lint for every module that configures a lint { } block."
 
     dependsOn(
+        ":app:lintDebug",
         ":auth:lintDebug",
         ":common:lintDebug",
         ":database:lintDebug",
+        ":e2eTest:lintDebug",
         ":firestore:lintDebug",
         ":library:lintDebug",
         ":storage:lintDebug",

e2eTest/build.gradle.kts

@@ -14,6 +14,20 @@ android {
         minSdk = Config.SdkVersions.min
     }
 
+    lint {
+        // Common lint options across all modules
+        disable += mutableSetOf(
+            "IconExpectedSize",
+            "InvalidPackage", // Firestore uses GRPC which makes lint mad
+            "NewerVersionAvailable", "GradleDependency", // For reproducible builds
+            "SelectableText", "SyntheticAccessor" // We almost never care about this
+        )
+
+        checkAllWarnings = true
+        warningsAsErrors = true
+        abortOnError = true
+    }
+
     compileOptions {
         sourceCompatibility = JavaVersion.VERSION_17
         targetCompatibility = JavaVersion.VERSION_17

okf-bundle/ci-workflows/android.md

@@ -46,7 +46,7 @@ Step 4 is **Java-only** (`include("**/*.java")`), so it inspects zero files in t
 
 Separate workflow, `pull_request` only, running `./gradlew --max-workers=2 lintAll`.
 
-`lintAll` is registered in the root `build.gradle.kts` and gates the 8 modules that configure a `lint { }` block; `:app` and `:e2eTest` are not yet among them (CPRN-433).
+`lintAll` is registered in the root `build.gradle.kts` and gates all 10 modules that configure a `lint { }` block.
 
 It is a separate workflow rather than a step in `build.sh` for two reasons. Lint measured **~4-5 minutes** on this repo — the `build` job went from 3-6 min to 8-11 min when it was inline — so running it in parallel roughly halves PR feedback time at about the same total runner cost, since the extra compile the lint job pays is the one `build.sh` stops paying (`lintAnalyze` depends on `compileDebugKotlin`, and there is no remote build cache: Develocity here is configured for build scans only). And under `set -e` an inline lint failure aborted the run **before** `testDebugUnitTest`, so one new finding cost you every test result for that run.