Adopt vecorel-cli 0.2.18, and convert JP through its DuckDB converter - #280
Merged
Merged
Conversation
The Fude polygons are published per year and the converter knew one of them. All four are variants now, newest first, with the test fixture last so it is not chosen by accident. The determination date used to be a constant for the whole file. Each parcel carries its own issue year, which becomes its determination:datetime in the SQL migration — the point of converting this dataset with SQL rather than in memory: 33 GB of Parquet across the four editions. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DVx9uQV2QPM8ecPAY3ZjXG
vecorel-cli 0.2.18 carries the SQL converter this repository had a copy of (vecorel/cli#29), so jp imports DuckDBBaseConverter and the copy can go. It also carries the checks the structural PRs here were proposing — rows that cannot validate dropped under max_dropped_share, the required properties read from the declared schemas rather than a hardcoded list, unique ids, no converter declaring both sources and variants, schemas fetched up front. Those checks fire on two converters as soon as the pin moves, so their fixes come along: hr declared a rolling `sources` beside its variants, which made every --variant convert the current file, and Europe-LAND's LT 2024 ships an empty crop_code beside a populated crop_name. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DVx9uQV2QPM8ecPAY3ZjXG
This was referenced Sep 13, 2026
m-mohr
reviewed
Sep 13, 2026
m-mohr
approved these changes
Sep 15, 2026
ivorbosloper
added a commit
that referenced
this pull request
Sep 16, 2026
The Saarland WFS refuses a request without a User-Agent, which the downloader only sends from 0.2.18 (vecorel/cli#30): the same page is 155 kB on 0.2.18 and a FileNotFoundError on 0.2.16. main gets this through #280. Every converter built from this branch now runs under 0.2.18's checks: bounded row drops, required properties from the declared schemas, and the id uniqueness warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt vecorel-cli 0.2.18, and convert JP through its DuckDB converter