NZ: both editions, from manually downloaded files - #253
Closed
ivorbosloper wants to merge 1 commit into
Closed
ivorbosloper wants to merge 1 commit into
ivorbosloper wants to merge 1 commit into
Conversation
This was referenced Sep 11, 2026
ivorbosloper
force-pushed
the
split/nz
branch
from
September 12, 2026 12:51
a444e0c to
3fe56fc
Compare
Koordinates requires a login, so the archives cannot be fetched by the converter. Both editions are variants that resolve their file from the cache folder, which is where a manual download lands. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DVx9uQV2QPM8ecPAY3ZjXG
ivorbosloper
force-pushed
the
split/nz
branch
from
September 12, 2026 15:11
3fe56fc to
da88b25
Compare
m-mohr
reviewed
Sep 15, 2026
Comment on lines
+11
to
+16
| data_access = """ | ||
| Download manually (Koordinates login required) and place the zip in the cache folder: | ||
| - 2020: https://data.mfe.govt.nz/layer/105407-irrigated-land-area-raw-2020-update/ (mfe-irrigated-land-area-raw-2020-update-SHP.zip) | ||
| - 2017: https://data.mfe.govt.nz/layer/90838-irrigated-land-area-2017/ (mfe-irrigated-land-area-2017-SHP.zip) | ||
| Alternatively pass the zip with the `-i` CLI parameter. | ||
| """ |
Contributor
There was a problem hiding this comment.
I think we should generally go via the -i parameter and not expose this cache folder workaround.
Collaborator
Author
There was a problem hiding this comment.
Agreed. I will close this PR
Collaborator
Author
|
Keep manual download fed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Koordinates requires a login, so the archives cannot be fetched by the converter: 2017 and 2020 are variants that resolve their file from the cache folder, which is where a manual download lands.