ES-IB: editions 2022-2026, and the right provider - #251
Merged
Merged
Conversation
This was referenced Sep 11, 2026
ivorbosloper
force-pushed
the
split/es_ib
branch
from
September 12, 2026 12:50
3a8a272 to
c07b062
Compare
m-mohr
reviewed
Sep 12, 2026
ivorbosloper
force-pushed
the
split/es_ib
branch
2 times, most recently
from
September 12, 2026 16:21
cb6eabe to
e01eec3
Compare
ivorbosloper
force-pushed
the
split/rest-mixin
branch
2 times, most recently
from
September 12, 2026 20:16
8170edb to
cc57c18
Compare
The yearly layers moved out of GOIB_SIGPAC_IB into GOIB_SIGPAC_HISTORIC_IB, which keeps 2022-2025; what is left in the first service is one current-state layer, ahead of the historic newest (maig against gener 2026). Each variant names the service it comes from. The years before 2022 are withdrawn. Both services join their parcels to the municipality and land-use tables, so their fields arrive table-qualified; the mixin strips that. The snapshot month they carry becomes determination:datetime through column_migrations — the current service writes "maig 2026", the historic ones "Febrer2024.0". `provider` also pointed at Navarra, a copy-paste between the Spanish converters. The converter had no test. It has one page of each service now, 100 features as the service answers them, so the qualified names and both spellings of the snapshot month are covered. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DVx9uQV2QPM8ecPAY3ZjXG
ivorbosloper
force-pushed
the
split/es_ib
branch
from
September 12, 2026 20:17
e01eec3 to
fbcfdfb
Compare
ivorbosloper
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #232 — review that one first.
The yearly layers moved out of
GOIB_SIGPAC_IBintoGOIB_SIGPAC_HISTORIC_IB, which keeps 2022-2025. What is left in the first service is one current-state layer, ahead of the historic newest (maig against gener 2026), so 2026 comes from there and each variant names the service it belongs to. The years before 2022 are withdrawn.Both services join their parcels to the municipality and land-use tables, so their fields arrive as
SIGPAC_FOGAIBA.DN_OID; #232 strips that for every REST converter, andes_cbloses its own copy of the same loop in #235. The snapshot month becomesdetermination:datetimethroughcolumn_migrations— "maig 2026" in the current service, "Febrer2024.0" in the historic ones.provideralso pointed at Navarra, a copy-paste between the Spanish regional converters.The converter had no test. It has one page of each service now, 100 features as the service answers them, so the qualified names and both spellings of the snapshot month are covered.