chore: move the starters onto the current seamless auth packages - #84
Merged
Conversation
Bump @seamless-auth/react from 0.9.0 to 0.11.0 in both React starters, @seamless-auth/express from 0.12.0 to 0.13.0, and @seamless-auth/fastify from 0.3.1 to 0.4.0. All three are 0.x minors, so the caret ranges pinned here would never have resolved to them on their own. The adapter bumps are pass-through. Both now forward a redirectUri from the magic link request body, and neither moves a type or a route the starters touch, so the version is the whole change there. The React bump drops --seamless-disabled, which 0.11.0 stopped reading when the disabled submit button became the enabled button at reduced opacity. Removed from shared/react-app/index.css and synced into both starters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps every Seamless Auth package the starters depend on, and follows through on the one change that reaches template code.
Versions
@seamless-auth/react@seamless-auth/react@seamless-auth/express@seamless-auth/fastifyAll three are 0.x minors, so a caret range on the old version never resolved to them. A project scaffolded from these templates stayed on whatever was pinned here.
What the bumps needed
The published type surfaces and bundles were diffed old against new, rather than reading version numbers and guessing.
Express and Fastify: no code change. Type surfaces, READMEs, and file lists are identical between versions. The only behaviour change is a pass-through: both adapters now forward a
redirectUrifrom the magic link request body to the auth API. The starters mount the adapter and nothing else, so the version bump is the whole change.React: one change. 0.11.0 stopped reading
--seamless-disabled, when the disabled submit button became the enabled button at reduced opacity instead of a filled grey. The token was set inshared/react-app/index.css, so it is removed there andnpm run sync:sharedcarried it into both starters' copies. Every other--seamless-*token is untouched.Two bundled-screen behaviour changes arrive that no starter code drives: passkey enrolment no longer asks for a device name before the browser prompt, and the sign-in screen now explains a disabled submit in a live region.
Not included
0.10 and 0.11 add capability the starters do not use:
AuthProvider'smagicLinkRedirectUri,returnToonfinishOAuthLogin, anattachmentforregisterPasskey, andgetPasskeyPolicyErrorCode(). Adopting any of them is a feature change rather than follow-through on a version, so they are left for their own pull request.Worth noting for that one: the OAuth starter's own callback page hardcodes
navigate("/"). That stays correct here, because its login sends noreturnToand the field comes back absent, but the bundled view now honours a destination and the starter does not demonstrate it.Verification
npm run validateand the rootformat:checkpass. In each of the four templates,npm install(confirming 0.11.0, 0.13.0 and 0.4.0 resolved), thennpm run checkandnpm run build:Lockfiles also pick up transitive
joseandzodbumps, as a normal consequence of reinstalling against the new resolutions.