Skip to content

fix(verify): follow the React SDK past its passkey naming step #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bccorb merged 1 commit into from
Sep 4, 2026
Merged

fix(verify): follow the React SDK past its passkey naming step #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .changeset/verify-passkey-naming-step.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
'seamless-cli': patch
---

Follow the React SDK's passkey enrollment through the removal of its naming step.

`@seamless-auth/react` used to open a "Name This Device" modal after "Register Passkey" was
pressed, and the harness typed into it before the WebAuthn ceremony would start. That view is
gone from the SDK, so `registerWithPasskey` waited 30 seconds for a placeholder that no longer
renders and then timed out, failing `react/passkeyRegister.spec.ts` and `react/passkeyLogin.spec.ts`
(which registers before it signs back in).

The helper now stops at the button, which is where the ceremony begins. This tracks the SDK
release that drops the modal, so a `--local` run against an older React checkout, or a published
run before that release lands on npm, will fail on the modal this no longer dismisses.
2 changes: 0 additions & 2 deletions verify/harness/lib/reactFlows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@ export async function registerWithPasskey(page: Page, email: string): Promise<vo
page.getByRole('heading', { name: /Secure Your Account with a Passkey/ }),
).toBeVisible();
await page.getByRole('button', { name: 'Register Passkey' }).click();
await page.getByPlaceholder(/MacBook/).fill('Verify Device');
await page.getByRole('button', { name: 'Continue' }).click();
}

/** Sign in an existing user whose passkey is registered (the ceremony auto-runs). */
Expand Down
Loading