Fix vscode blame username - #1418
Open
Mukesh-SCS wants to merge 1 commit into
Open
Conversation
|
This pull request has been imported. If you are a Meta employee, you can view this in D116501720. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #719.
VS Code inline blame currently uses the OS username to determine whether a commit should be annotated with
(you). This can produce false matches when the OS username appears in another author's name or email.This change uses Sapling's configured
ui.usernameinstead.The username is loaded once per repository and cached with the existing blame state. Blame loading waits for the username lookup to finish so the first annotation is rendered with the correct identity.
If
ui.usernameis missing or cannot be read, commits are not marked as(you). Local uncommitted changes continue to display(you) • Local Changes.Test Plan
Added regression coverage for:
ui.usernameui.usernameui.usernameonly once per repositoryui.usernamebefore the first blame render(you)for local uncommitted changesRan:
npx --yes yarn@1.22.22 workspace sapling-scm test extension/blame/__tests__/blame.test.ts --runInBandResult: 15 tests passed
Also ran:
Lint completed with no errors in the changed files.