Make HTTPCodecFilterChain an isolated class (behaviour preserving) - #644
Open
DenisYaroshevskiy wants to merge 1 commit into
Open
DenisYaroshevskiy wants to merge 1 commit into
DenisYaroshevskiy wants to merge 1 commit into
Conversation
Summary: Instead of calling `codec_->` and all the chain methods, we want to encapsulate them together. That way we can optimize them in the diffs to follow. This diff just does the encapsulation. This is mechanical and behaviour-preserving. The bulk of the diff is `codec_->foo()` becoming `codec_.foo()` across `HTTPSession`, `HQSession`, `HTTPCoroSession` and their tests. The only problem with exposing both Chain and Codec methods was with `setCallback` that is available on both today. The only call site `HQSession::initIngress` where `->setCallback` was used is behaviourally identical in this diff. (it will be fixed on top) Differential Revision: D120697369
Contributor
|
@DenisYaroshevskiy has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120697369. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Instead of calling
codec_->and all the chain methods, we want to encapsulate them together.That way we can optimize them in the diffs to follow.
This diff just does the encapsulation.
This is mechanical and behaviour-preserving. The bulk of the diff is
codec_->foo()becomingcodec_.foo()acrossHTTPSession,HQSession,HTTPCoroSessionand their tests.The only problem with exposing both Chain and Codec methods was with
setCallbackthat is available on both today.
The only call site
HQSession::initIngresswhere->setCallbackwas used is behaviourally identical in this diff.(it will be fixed on top)
Differential Revision: D120697369