fix: malformed supporter SVGs — Boeing/Ribose invisible, NIST oversized - #58
Merged
Conversation
boeing/ribose shipped viewBox-only SVGs (no intrinsic width/height), so the logos collapsed to nothing under w-auto + height caps; nist shipped width/height without a viewBox, so its content could not scale and rendered oversized (ge had the same latent problem). Give all four both a viewBox and explicit dimensions, and set a definite h-10 on the logo strips so every logo renders at the same height. scripts/assets.test.ts guards the invariant: every supporter SVG must carry a viewBox and explicit width/height.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the invisible Boeing/Ribose logos and the oversized NIST logo.
Why: an
<img>-embedded SVG needs both aviewBox(so the content scales) and explicitwidth/height(so layout has an intrinsic size). The supporter assets violated this in both directions:w-auto+ height capAll four now carry both. Logo strips (home + /supporters) also use a definite
h-10instead ofmax-h-10so every logo renders at the same height deterministically.Guard:
scripts/assets.test.ts— every SVG inpublic/images/supporters/must have aviewBoxand explicitwidth/height; runs in CI vianpm test(14 tests total, all green).