perf: snappier lists, diffs and repository opens - #22
Merged
Merged
Conversation
Render only the rows in view (plus overscan) in TextDiff, ChangesTab and HistoryTab through a shared useWindowedRows hook; syntax highlighting, split-view pairing and intraline diffs are computed lazily per block as rows scroll in. Memoize DiffPane and the list rows, narrow App's store selectors, drive the sidebar drag from the DOM and share one RelativeTime timer.
Dedupe concurrent `remote -v` calls, read identity and signing config with one `config --get-regexp` per scope, walk submodules and repository indicators a few at a time, pass check-attr paths over stdin, and bail out of oversized conflict files before parsing them.
The watcher already coalesces bursts, so the renderer's second 150 ms timer only added latency. Shorten the watcher debounce to 120 ms and ignore churn under node_modules and similar cache directories.
Carry the listbox/option keyboard-access attributes from the UI audit onto the windowed FileRow and CommitRow components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiffPaneand list rows are memoized,Appselectors narrowed, sidebar drag driven from the DOM, one sharedRelativeTimetimer.remote -v, oneconfig --get-regexpper scope for identity/signing, concurrent submodule/indicator walks,check-attr --stdin, size guard on conflict files.repo.changed: watcher debounce 350 → 120 ms, renderer's second 150 ms timer removed,node_modules/cache churn ignored.Verification
npm run typecheckcleanvitest run: 81 files, 1071 passed, 4 skipped (newtest/windowing.test.tscoversvisibleRange)Notes for review
getConfigIdentitywith no repo now reads global scope only (system/etc/gitconfigno longer consulted).node_modules,__pycache__,.cache,.venv,.ideaat the worktree root.