Fix UI/UX audit findings: keyboard access, dialog focus, labels, contrast, safety guards - #21
Merged
Merged
Conversation
…t, safety guards - Dialog: aria-labelledby, focus trap, restore opener on close - List rows (commits, files, stashes): role=option, tabIndex, arrow/Enter/Shift+F10 navigation - TextField/FilterInput/Settings: associate labels, aria-describedby, aria-invalid - Contrast: --fg-subtle both themes, dark --success-hover now >=4.5:1 - prefers-reduced-motion: drop dialog/toast/flash animations, slow spinner - Commit form: summary input gets its own row; AI actions move to the actions row - History/stash file pane: width min(280px, 32%) so the diff gets room at 960px - Use ours/theirs: success toast with Undo (git.conflict.unresolve) - Abort merge/rebase/cherry-pick/revert: confirm first - History list/details, Welcome health, large-file scan: inline error + Retry instead of empty-state copy
…, cover ReviewView list - listKeys: Enter/Space only activate when the row itself is focused - Dialog: capture opener before autoFocus, prefer live outside-dialog focus, restore even from context-menu-opened dialogs; Tab with no focusables stays put - ContextMenuHost: focus first item on open, ArrowUp/Down cycle, restore opener on close - ReviewView file list gets role=listbox + key handler - selectCommit clears detailsError; LargeFilesCard resets blobs per repository
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the 10 findings from a UI/UX audit of the built app (Linux, 1280x760 and the 960x620 minimum window). No visual redesign; targeted interaction/a11y/safety fixes.
Accessibility
aria-labelledbyfrom the heading, Tab/Shift+Tab trapped inside the topmost dialog, focus restored to the opener on close (also when the dialog was opened from a context menu).role=option, focusable, ArrowUp/Down/Home/End, Enter/Space select, Shift+F10/ContextMenu opens the row menu. Context menu now takes focus, ArrowUp/Down cycle items, Escape returns to the row.TextFieldassociates label/hint/error (htmlFor,aria-describedby,aria-invalid); every settings select/number input gets a<label for>;FilterInputgets anaria-label.--fg-subtle3.04→4.55:1, dark 3.77→5.14:1; dark--success-hover(white text) 3.37→5.33:1.prefers-reduced-motion; spinner slowed, not stopped.Layout
width: min(280px, 32%)so the diff keeps ~450 px at the 960 px minimum.Workflow safety / recovery
git.conflict.unresolve).Verification
npm run typecheck,npm run test:unit(750 pass).GITGOOD_USER_DATAprofile with a temp repo: dialog name/trap/restore, keyboard row navigation + Shift+F10 menu, Space on include checkbox still toggles, Use-ours → Undo restores conflict markers, Abort confirm cancel/confirm, reduced-motion emulation, contrast tokens.