Add Windows WebView2 host with CI and release jobs - #3
Merged
Conversation
Implement the C++/Win32/WebView2 native host, wire shared Elixir E2E on Windows, and add windows-e2e CI plus release artifact packaging. Co-authored-by: Cursor <cursoragent@cursor.com>
Deduplicate UTF-8/path helpers, drop dead icon/menu state, harden RPC framing and permission deferrals, and fix the Windows build script generator fallback. Co-authored-by: Cursor <cursoragent@cursor.com>
CI failed because test.webview.eval ran while CreateCoreWebView2Controller was still pending and returned an error map instead of a string. Co-authored-by: Cursor <cursoragent@cursor.com>
…iew2 ready. Master E2E now requires test.tray.list and test.session.reset. Also stop waiting on NavigationCompleted before eval, which timed out on GitHub runners. Co-authored-by: Cursor <cursoragent@cursor.com>
GitHub windows-latest was hanging test.webview.eval; show the controller and pass software/GPU flags used by other CI WebView2 hosts. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
native/windows/, withscripts/build_windows.ps1producingpriv/native/windows/DesktopWebView.exe.taskkillcleanup) and updatedocs/status/windows.mdfor E2E-covered features.windows-e2ejob (build host +mix test) and release packaging forDesktopWebView-windows-x64.exe.Test plan
windows-e2ejob is green.\scripts\build_windows.ps1thenmix test --only e2ewithDESKTOP_WEBVIEW_BINARYsetlistening <port>smoke and WebView2 Runtime is present on the runnerDesktopWebView-windows-x64.exe(+.sha256)