fix: Rotation not applied on preview on initial load - #456
Merged
Merged
Conversation
leolost2605
requested changes
Aug 17, 2026
leolost2605
left a comment
leolost2605
left a comment
Member
There was a problem hiding this comment.
Makes sense but I would make the Gtk.Label a field instead of passing it to the method. Most notably because if it's a local variable using it in a lambda will cause a memory leak.
Contributor
Author
|
That is good to know, thanks. I hesitated about that anyway so I will apply your suggestion. |
flodavid
force-pushed
the
fix-rotation-not-loaded
branch
from
August 17, 2026 15:06
6721d3f to
cb2792a
Compare
flodavid
force-pushed
the
fix-rotation-not-loaded
branch
from
August 17, 2026 15:15
cb2792a to
f85c845
Compare
Contributor
Author
|
It is applied |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #455.
on_vm_transform_changed ();has been removed at the end ofDisplayWidget's constructor by #450, when it should have been replaced by a new method to initialize the rotation.