Skip to content

ProcessTreeView: clean up - #569

Open
danirabbit wants to merge 3 commits into
mainfrom
danirabbit/processtreeview-cleanup
Open

danirabbit wants to merge 3 commits into
mainfrom
danirabbit/processtreeview-cleanup

Conversation

@danirabbit

Copy link
Copy Markdown
Member
  • Gobject-style construction
  • Name doesn't need to be bound because name and icon never change in the source object
  • Name doesn't need an unbind because its values are only set once in bind
  • DRY label unbind
  • Don't need to manually set expand = false on non-expanded columns
  • Don't need to hexpand name labels because the column is set to expand and labels fill by default
  • Rename functions to start with the thing they do (setup_, bind_, unbind_)
  • Organize and clean up extra variables

@danirabbit
danirabbit requested a review from a team September 17, 2026 20:41
Comment thread src/Views/ProcessView/ProcessTreeView/ProcessTreeView.vala Outdated
@danirabbit
danirabbit requested a review from lenemter September 17, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants