Conversation
We separate the formatting of values and units, using the IEC_UNITS flag for the former and excluding it for the latter. This would cause the function to sometimes show the next higher unit for values close to the conversion borderline for IEC versus non-IEC unit values. For example, if the provided network speed parameter is 1020 Mbit/s the non-IEC formatting would pick "Gbit/s" as the unit because it's over the 1000-base mark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #561
We separate the formatting of values and units, using the
IEC_UNITSflag for the former and excluding it for the latter.This would cause the function to sometimes show the next higher unit for values close to the conversion borderline for IEC versus non-IEC unit values.
For example, if the provided network speed parameter is 1020 Mbit/s the non-IEC formatting would pick "Gbit/s" as the unit because it's over the 1000-base mark.