Add processor and graphics header label titles

[vjr]

Be consistent with other sections in the system view viz. memory, network and storage.

[stsdc]

I actually wanted to go another way and replace generic text with the actual hardware names, if we have some.
I think we can save some space by just prepending hardware name with its type: "Processor: Intel Smoothie Lake ..."

[danirabbit]

@stsdc I think using header with secondary text is better than combining strings with : and for most people " Intel Smoothie Lake…" probably doesn't mean anything at all. Maybe "Intel" is a big enough brand name to know it's a processor, but otherwise the actual hardware names are probably not particularly interesting information unless you're using it to disambiguate.

Personally, I would even say to go the other way and not list any hardware names unless we're disambiguating like what Networking does. We do list hardware details already in System Settings.

The question I think to ask is, what problem does having the hardware name here solve? I'm not sure it does anything for us to have it

[vjr]

I think it's useful to keep it as a quick glance at CPU+GPU info, it's just a one-liner :-)

BTW I'm unable to figure out how to bottom-valign the round popover info-button, it looks a bit off towards the higher side to me, tried a few properties in Gtk.Box and the child MenuButton widget to no avail.

Done in a615632

[vjr]

hey @stsdc or @danirabbit can i get a quick rubberstamp approve on this? i think it's good to get in, can do further adjustments later on?

[stsdc]

@vjr
What if we move info button to right:

Hope popover will not look weird.

Make processor name selectable.

[vjr]

hi @stsdc moving the info-button to the right will lose its context meaning people won't know it is the info/details for the CPU I think... I'll try to align it to v-center or v-bottom if I can.

ok, i'll see about making the CPU model name selectable, thanks!

[vjr]

@stsdc i dont see a way to make it selectable since we use granite header-label :-( also i was struggling to figure out shifting the info-button popover icon a little to the center vertically, so that it's not too high up - do you know how i can do this - im sure it's straightforward but im just missing something obvious.

See:

#548 (comment)

and

#548 (comment)