Cleanup: fix some terminal warnings - #1801
Open
jeremypw wants to merge 4 commits into
Open
Conversation
jeremypw
marked this pull request as ready for review
August 17, 2026 17:25
danirabbit
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes terminal warnings originating from
The reason for the ProjectChooserButton warnings was not entirely clear but was caused by the custom "active" property being accessed when the action-name was set before the checkbutton was instantiated. It was fixed by using a different and more explicit property name.
In passing it was noticed that the "activated" signal of the menubutton was used instead of the "toggled" button and the handler was therefore non-functional.
For now the checkbutton state is handled explicitly - there may be a better way but that is outside the scope.
There are still quite a lot of (apparently upstream) warnings when tabs are closed and when the window is closed but these are not obviously due to Code code.