Fix locked release builds after version bumps - #429
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the release failure in run 35511336229. The version-bump job changed
Cargo.tomlfrom 13.2.0 to 14.0.0 without updating the workspace package entry inCargo.lock. All seven failed wheel jobs then stopped at Cargo metadata because their--lockedbuilds correctly refused to update the lockfile.cargo update --workspacebefore committing the release branch, updating the local package version while preserving dependency pins. Keep locked wheel builds enabled.Validation
cargo update --workspacefix the error and allow locked Cargo metadata to succeed. All 234 non-root dependency identities, versions, and sources remain unchanged.git diff --check: passed.make docs: passed with 307 warnings, matching the previously observed main warning count.Recovering the interrupted release
The failed run already created release PR #426 and
version-14.0.0. Its publish and tag/merge jobs were skipped. This PR intentionally leaves that release state untouched.After merging this fix, close the abandoned release PR and delete its generated branch before dispatching a fresh major release. Otherwise, the next bump will try to push the same branch name. Alternatively, update
Cargo.lockon the existing release branch and rerun the failed jobs from the original run. Simply rerunning the failed jobs without repairing that branch will retain the stale lockfile.