Fix(Processes): Make subterm hoisting deterministic across processes - #422
Merged
saulshanabrook merged 3 commits intoSep 18, 2026
Merged
saulshanabrook merged 3 commits into
saulshanabrook merged 3 commits into
Conversation
Signed-off-by: JingrenWang <wjrforcyber@163.com>
for more information, see https://pre-commit.ci
saulshanabrook
approved these changes
Sep 17, 2026
Member
|
Thank you for this! |
Member
|
@actions-user changelog |
Member
|
This was fixed in my other branch that integrates a bunch of upstream changes, but keeping this test case, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Shared-subexpression discovery used
set.pop(), so unspecified hash-table order—affected by Python's per-process hash randomization—could change which repeated nodes were discovered and hoisted first. This changed syntheticletnumbering and serialized e-graph output across otherwise identical processes.Fix
After integrating current
main,_exprs_multiple_parents()uses deterministic ordered DAG traversal with explicit incoming-edge counts, preserving source order and returning each shared node once.Test
The regression runs the same high-level program in fresh subprocesses with fixed
PYTHONHASHSEEDvalues 1, 2, and 3, then asserts that the public saved Egglog transcripts match. The previous set-based traversal produces different transcripts for these seeds.Changelog
Adds an
UNRELEASEDentry linking #422.