fix(json): make the JSON server's computation limit configurable - #2198
Merged
Conversation
The VSCode JSON language server computes document symbols and folding ranges without limit unless the client configures one. Wild Web Developer never sent any configuration, so a 100,000 line file produced 20,001 symbols and folding ranges per request, and with the Outline view open the UI thread spent seconds per keystroke rehashing that tree. Add a JSON preference page with the maximum number of computed items, defaulting to 5000 as VSCode and the existing YAML preference do, and 0 for no limit. The validate and http entries have to be sent along because the server re-reads every setting from each notification: without validate.enable it disables validation, and without http.proxyStrictSSL it stops verifying certificates when downloading remote schemas.
Contributor
Author
|
Are you okay with the shorted label as described here: |
Contributor
Yes, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VSCode JSON language server computes document symbols and folding ranges without limit unless the client configures one. Wild Web Developer
never sent any configuration, so a 100,000 line file produced 20,001 symbols and folding ranges per request, and with the Outline view open the UI thread spent seconds per keystroke rehashing that tree.
Add a JSON preference page with the maximum number of computed items, defaulting to 5000 as VSCode and the existing YAML preference do, and 0 for no limit. The validate and http entries have to be sent along because
the server re-reads every setting from each notification: without validate.enable it disables validation, and without http.proxyStrictSSL it stops verifying certificates when downloading remote schemas.