Add TH6250WF to UNMONITORED_DEVICES - #453
Open
njloof wants to merge 1 commit into
Open
Conversation
This 24V thermostat only opens/closes a relay and has no power sensing. Hilo reports power.value: None, which _map_power coerces to 0, making sensor.<device>_power show a false 0 instead of unavailable. Confirmed via the Hilo app showing no power reading for this device either. Fixes dvd-dev#451
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds TH6250WF to UNMONITORED_DEVICES per #451.
This device only toggles a 24V relay and has no power-sensing
capability, so power.value is always None from Hilo's backend.
_map_power currently coerces that to 0, making sensor._power
permanently show a false 0 rather than unavailable. Confirmed via
the Hilo app that it shows no power reading for this device either.
Tested on real hardware: patched UNMONITORED_DEVICES in the installed
pyhilo package on a live Home Assistant Green instance running this
device, confirmed sensor.th6250wf_power correctly stops updating and
shows unavailable instead of 0, across two restarts, with no
regressions to the device's other sensors (temperature, hvac_action,
etc).
Closes #451