Stop plain-portal codegen uniqueness test from flaking - #134
Merged
Merged
Conversation
…llisions The test drew 200 random codes from a ~3.4 million element space and asserted they were all distinct, which fails about once in 170 runs. Assert nearly-all-unique instead.
Contributor
|
Next steps:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_generate_many_uniquedrew 200 random codes and asserted all 200 were distinct. The code space is 99 numbers × 187 × 186 word pairs (about 3.4 million), so by the birthday bound 200 draws collide roughly once in 170 runs. It failed that way on the #89 CI run (assert 199 == 200).The test now asserts at least 190 of 200 are unique, which still catches a degenerate generator while being effectively impossible to hit by chance.