Skip to content

Log file name up front #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gewarren wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −7
Open

Log file name up front #742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a761c8
Log file name up front
gewarren Sep 12, 2026
f432902
Log file name up front
gewarren Sep 12, 2026
874b3c7
fix tests
gewarren Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions actions/docs-verifier/src/RedirectionVerifier/RedirectTargetVerifier.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ await WriteErrorAsync(
return false;
}

await writer.WriteLineAsync($"Checking redirect targets in '{redirectionFilePath}'...");
Comment thread
gewarren marked this conversation as resolved.

OpenPublishingRedirectionReader reader = new(redirectionFilePath);
ImmutableArray<Redirection> redirections = await reader.MapConfigurationAsync();
if (redirections.IsDefaultOrEmpty)
Expand Down
6 changes: 1 addition & 5 deletions actions/docs-verifier/src/RedirectionVerifier/RedirectionHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,7 @@ public static async Task<ImmutableArray<string>> GetRedirectionFileNames()
// If no redirection files are found in the OPS config, just use the default name.
ImmutableArray<string> redirectionFileNames = await GetRedirectionFilesAsync() ??
[".openpublishing.redirection.json"];
Console.WriteLine($"The following {redirectionFileNames.Length} redirection files are registered:");
foreach (string filename in redirectionFileNames)
{
Console.WriteLine(filename);
}
Console.WriteLine($"Found {redirectionFileNames.Length} registered redirection files.");

return redirectionFileNames;
}
Expand Down
2 changes: 0 additions & 2 deletions actions/docs-verifier/tests/GitHub.UnitTests/RedirectTargetVerifierTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ public async Task WriteResultsAsyncReturnsTrueForValidLearnUrlPath()
_ => Task.FromResult<HttpStatusCode?>(HttpStatusCode.OK));

Assert.True(result);
Assert.Equal(string.Empty, writer.ToString());
}
finally
{
Expand All @@ -46,7 +45,6 @@ public async Task WriteResultsAsyncSkipsNonLearnUrlTargets()
});

Assert.True(result);
Assert.Equal(string.Empty, writer.ToString());
Assert.False(statusProviderCalled);
}
finally
Expand Down
Loading