service/progress: treat completed one-shot tasks as converged - #7231
Open
locker95 wants to merge 1 commit into
Open
service/progress: treat completed one-shot tasks as converged#7231locker95 wants to merge 1 commit into
locker95 wants to merge 1 commit into
Conversation
stack deploy --detach=false waited forever for replicated services whose tasks exit 0 under restart_policy none/on-failure, because the waiter only counted Running. Swarm already marks those tasks DesiredState=Complete; count that as done too. Fixes docker#5299 Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker stack deploy --detach=falsenever returns if a replicated service is a one-shot (hello-world,restart_policy: on-failure, process exits 0). the waiter only countedRunning, so it sat there after swarm already set DesiredState to complete.count Complete+Complete as done, same as Running. Failed tasks still don't converge.
Fixes #5299