Make 70.dhclient.conf append ma1 client-id only once (Fixes #306) - #317
Open
gavin-Angry-Birds wants to merge 1 commit into
Open
gavin-Angry-Birds wants to merge 1 commit into
gavin-Angry-Birds wants to merge 1 commit into
Conversation
…ct#306) Boot used >> into /etc/dhcp/dhclient.conf every time, so the ma1 block grew on each reboot. Skip when the interface block already exists; keep the ONIE-compatible client-id behavior. Verified with MA1_MAC and a temporary DHCLIENT_CONF (no switch HW). Signed-off-by: gavin-Angry-Birds <gavincodegk@gmail.com>
gavin-Angry-Birds
force-pushed
the
fix/issue-306-dhclient-conf-idempotent
branch
from
September 7, 2026 08:41
d31b7b2 to
c01b2d4
Compare
paulmenzel
reviewed
Sep 7, 2026
paulmenzel
left a comment
paulmenzel
left a comment
Contributor
There was a problem hiding this comment.
Thank you for your patch.
Please amend the commit and take the Fixes: out of the summary/title, and add the tag
Resolves: https://github.com/dentproject/dentOS/issues/306
to the bottom of the body.
Also, if possible, please use your full name in the author field and Signed-off-by: line instead of gavin-Angry-Birds.
Regarding the diff, it looks like a valid approach, despite a better general design, where and how the line is added, might be preferable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
>>on every boot, duplicating the ma1 blockinterface "ma1"is already presentTest plan
boot.d/70.dhclient.conf: Appends management interface entry at each boot #306Notes
No DENT switch hardware on my side; please say if you want a different guard (e.g. match full client-id line).