Fix/hot reload shutdown - #8
Open
DBeardionaire wants to merge 2 commits into
Open
DBeardionaire wants to merge 2 commits into
DBeardionaire wants to merge 2 commits into
Conversation
Author
|
I also see a test failing locally in LargeGraphTests that I didn't include in case it should be handled separately or is just failing on my machine JsxCore/test/JsxCore.Tests/Unit/PackageManagement/Native/LargeGraphTests.cs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected HMR WebSockets can keep requests alive during application shutdown, delaying the host from stopping. I 1st saw this when using aspire rebuild/restart and then with
dotnet runandCtrl + C.Registers the hot reload service with
IHostApplicationLifetime.ApplicationStoppingso shutdown aborts connected sockets and unsubscribes from build notifications. Guarded client registration so connections arriving during shutdown are also aborted, and reuse the cleanup during disposal.Adds a component regression test that connects an HMR client, triggers application stopping, and verifies the service clears its connected clients.