Add request_source field - #19
Open
Gutts-n wants to merge 1 commit into
Open
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Records a new
request_sourcefield on every analytics event emitted byAnalyticsMiddleware, read from theRequest-Sourcerequest header.Nonewhen the header is absent (the common case).Why
Part of the NESO API-usage-metrics work (neso-nextgen-shared#152). Data
Explorer already sends
Request-Source: data-exploreron its calls to thisservice (see neso-nextgen-shared#145). Without capturing that header in the
event payload, there is no way to tell Data Explorer traffic apart from
genuine external API use downstream, so it inflates the usage figures.
This only adds the field to the event shape - filtering it out of the
dashboards happens in neso-monitoring. Same change was also made to
ckanext-analytics for the CKAN Action API side (datopian/ckanext-analytics#1),
since the two services feed one shared BigQuery table.
Verified
pytest- 481 passed.ruff check- clean.None.Not verified: end-to-end against a live pipeline (Loki -> BigQuery -> Grafana).