Conversation
Unify chart card architecture by standardizing all charts onto uniform `ChartSeries` arrays, and moving observation facets directly into series models, general series functionality consolidation.
…re `focusTarget` receives the parent shape ID for camera framing, and prevent double-prefixing during canvas card creation.
…d synthesized child result titles
…et observation resolution
…t facet resolution, conversion of inline strings to constants, and various cleanup items. Add comments
…ture click navigation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the chart card state management and rendering logic in the Atlas workspace. Key changes include simplifying the facet data structure by embedding facets directly within chart series, introducing a canonical buildCardShapeId helper to prevent duplicate cards, and adding support for child-place scoped cards (via resultPlaceDcid) which allows drilling down into specific entities (e.g., from a choropleth map click). It also bumps the serialized state version to 2 and introduces comprehensive unit tests for facet resolution, shape ID generation, and store synchronization. I have no feedback to provide as there are no review comments to assess.
nick-nlb
marked this pull request as ready for review
September 11, 2026 20:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The original goal of this PR was to add in the ability to generate time series charts by clicking entities in the choropleth charts (functionality seen in the demo).
However, work on this task highlighted the need to improve the overall store, chart and data architecture underlying the appllication, to make it cleaner, efficient and extensible. This became the primary focus of the PR.
As part of that effort, this PR:
In addition, the PR implements the card spawning itself (leaving accessibility as a follow-up). When a choropleth map entity is hovered, it is also clickable. Clicking the entity will produce a new card with the full time series associated with that entity. These individual charts can then be combined and manipulated like normal charts.
Issues
Address tracker items 48 and 49.
Upcoming Issues
A follow-up to this will be the TODO added into this PR, to make the functionality associated with the spawning keyboard, etc, accessible
Screenshots