Skip to content

OpportunityInsightsOutcomes_statvar_processor_migration - #2227

Open
balit-raibot wants to merge 14 commits into
datacommonsorg:masterfrom
balit-raibot:OpportunityInsightsOutcomes_statvar_processor_migration
Open

balit-raibot wants to merge 14 commits into
datacommonsorg:masterfrom
balit-raibot:OpportunityInsightsOutcomes_statvar_processor_migration

Conversation

@balit-raibot

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a new data import pipeline for the Opportunity Insights Opportunity Atlas Outcomes dataset, including scraping, downloading, preprocessing, and testing scripts. The feedback highlights several opportunities to make the pipeline more robust: explicitly filtering out common missing value placeholders (such as 'NA' or '.'), handling float-like strings when formatting FIPS and CZ codes, raising exceptions instead of warnings when expected files are missing to ensure early pipeline failure, and improving the macOS metadata exclusion logic when extracting ZIP files.

Comment thread statvar_imports/opportunity_insights_outcomes/preprocess.py Outdated
Comment thread statvar_imports/opportunity_insights_outcomes/preprocess.py
Comment thread statvar_imports/opportunity_insights_outcomes/preprocess.py Outdated
Comment thread statvar_imports/opportunity_insights_outcomes/download.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant