Revert the dappnodesdk 0.3.52 pin - #8
Merged
Merged
Conversation
The pinned run failed identically with ResolverNotFound. Both 0.3.52 and 0.3.53 declare @dappnode/toolkit ^0.1.21, and the toolkit declares ethers ^6.9.0, so a fresh install resolves a current ethers whatever the dappnodesdk version is, and that raises ResolverNotFound rather than NOREPO. The earlier local test suggesting otherwise was invalid: it used a globally installed copy whose dependency tree was frozen at install time. The fix belongs in DAppNodeSDK and is proposed in dappnode/DAppNodeSDK#480. This package can publish once a release carrying it is on npm. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pin did not work — the run with it applied failed identically:
Why pinning cannot work
Both ranges float, so a fresh CI install resolves a current ethers regardless of which dappnodesdk version is requested — and current ethers decodes the ENS custom error as
ResolverNotFoundinstead of reportingNOREPO.My earlier local test that showed
0.3.52working was invalid: it resolved to a globally installed copy whose dependency tree was frozen at install time, not a fresh resolve. Apologies for the detour.The real fix
dappnode/DAppNodeSDK#480 makes both first-publish guards recognise
ResolverNotFoundalongside the older spellings. This package can publish once a dappnodesdk release carrying that lands on npm; the workflow goes back to unpinned here so it picks it up automatically.🤖 Generated with Claude Code