Fix dark mode for MDX disclosures - #324
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human
AI
In dark mode, the TALA announcement's “Sources and rendering details” disclosure uses nearly white text on a pale background. Apply the existing dark admonition background to Docusaurus
details.alert--infoelements so the collapsed label and expanded contents are readable. Light mode and diagram colors are unchanged.Validation: production build passed for English and Korean; repository-pinned Prettier 2.8.1 at print width 90 and
git diff --checkpassed. Verified collapsed and expanded dark states, plus light mode, in macOS Safari Responsive Design Mode at 375 × 667 and 2×. Actual iOS Safari was not available for testing.