Fix background failure reporting and D2 formatting - #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human
AI
CI could report success after a background job had already failed, and changed
.d2files were never passed to the formatter. Record each background process ID at launch withrunjob_bg, wait for every recorded status, and remove the misplaced formatter argument. Migrate this repository's parallel callers and preserve existing job filters.Remove implicit
nofixupschecks from cleanup and notifications so each consuming repository can choose its commit-message policy. The standalone check remains available. D2's companion PR d2lang/d2#2877 removes its explicit job and adopts this helper commit.Consumers must replace
runjob ... &withrunjob_bg ...before updating; visible unregistered background jobs now fail with a migration message.Validation: full helper test suite under
shanddash; focused completed-job, nested-job, cancellation, formatter invocation/failure, and cleanup/notification regressions; full helper CI; regenerated bundle consistency and shell syntax checks.