feat: support compose image volumes - #5161
Open
papidb wants to merge 1 commit into
Open
Conversation
Signed-off-by: Daniel Benjamin <benjamindaniel706@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Compose long-syntax image volumes by translating them to the existing
--mount=type=imageimplementation.The Compose path now resolves image sources that reference active or disabled services, ensures missing mount-source images before the child command runs with
--pull=never, and validates image-specific options before project resources are created. Image mounts remain read-only.image.subpathwas intentionally left alone until the lower-level support in #4993 is available.Tests cover external and service-referenced sources, source pulling, read-only behavior, malformed definitions, mount-field injection, unchanged legacy volume arguments, and cleanup.
Related to #4767.