Use cfg_select! for conditional compilation based on target_feature - #895
jgilchrist wants to merge 1 commit into
Conversation
e644c9b to
36f6c24
Compare
Ups the Rust requirement to 1.95, so may be a while before this could be merged. But is a _much_ nicer way of expressing this pattern.
36f6c24 to
f0c1016
Compare
| ft_out: &Aligned<[u8; L1_SIZE]>, nnz_table: &[SparseEntry], | ||
| ) -> (Aligned<[u16; L1_SIZE / 4]>, usize) { | ||
| use std::arch::x86_64::*; | ||
| cfg_select! { |
There was a problem hiding this comment.
Definitely an argument that it's trickier to read for these larger functions, so will revert if others agree
jgilchrist
changed the title
|
@codedeliveryservice How are you feeling about this? CI is on 1.97, but are you keen to maintain compatibility for <1.95? Happy to rebase. |
|
The change itself seems great, however, I'm not sure how I feel about it. My only concern is that the OpenBench machines are running older versions (1.92.0 and 1.94.0), with the largest machine kindly connected to it but without any direct access to the machine itself. |
Totally understand, happy to leave this sitting until versions have progressed enough to make this an easier call! |
2 participants
Ups the Rust requirement to 1.95, so may be a while before this could be merged. But is a much nicer way of expressing this pattern.