Document more source types v2 - #610
Open
jorbaum wants to merge 5 commits into
Open
Conversation
jorbaum
force-pushed
the
document-more-source-types-v2
branch
from
August 20, 2026 07:47
fa0559a to
b74ae11
Compare
I took a deeper look to double check and adjusted as per my findings
jorbaum
force-pushed
the
document-more-source-types-v2
branch
from
August 20, 2026 07:48
b74ae11 to
3c71eb1
Compare
chombium
suggested changes
Aug 20, 2026
Contributor
Author
|
@chombium thanks for the review. I worked in most of your comments. Marking it ready for review now even though I left the one comment about the newline unresolved. |
jorbaum
marked this pull request as ready for review
August 21, 2026 09:26
chombium
reviewed
Aug 21, 2026
chombium
suggested changes
Aug 21, 2026
jorbaum
force-pushed
the
document-more-source-types-v2
branch
from
August 21, 2026 13:50
9f20694 to
ddfde5b
Compare
chombium
reviewed
Aug 21, 2026
chombium
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #577 / #609 .