os-morphing: fix static ip configuration if the mac changes - #505
Merged
Conversation
Dany9966
reviewed
Aug 24, 2026
petrutlucian94
force-pushed
the
static_ip_changed_mac
branch
2 times, most recently
from
August 24, 2026 15:43
bf1188a to
063eec1
Compare
When "use_dhcp" is disabled, Coriolis tries to apply static IP configuration on Windows, while on Linux it defines udev rules for preserving the interface names, identifying interfaces by MAC address. However, it expects the MAC address of the source instance to be preserved, which isn't always the case. This change updates the Linux and Windows OS morphing code to use the new MAC address, if provided. The import provider is expected to set "new_mac_address" with the nic info if the original MAC hasn't been preserved. Note that Coriolis cannot modify network configuration files at the moment. An exception will be raised if the original MAC address is explicitly set by the network configuration (e.g. netplan).
petrutlucian94
force-pushed
the
static_ip_changed_mac
branch
from
August 24, 2026 15:57
063eec1 to
4962d7d
Compare
Dany9966
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When "use_dhcp" is disabled, Coriolis tries to apply static IP configuration on Windows, while on Linux it defines udev rules for preserving the interface names, identifying interfaces by MAC address.
However, it expects the MAC address of the source instance to be preserved, which isn't always the case.
This change updates the Linux and Windows OS morphing code to use the new MAC address, if provided. The import provider is expected to set "new_mac_address" within the nic info if the original MAC hasn't been preserved.
Note that Coriolis cannot modify network configuration files at the moment. An exception will be raised if the original MAC address is explicitly set by the network configuration (e.g. netplan).