[review only, do not merge] x-client 0.3.0 modernisation diff - #2
Draft
ggreif wants to merge 1 commit into
Draft
Conversation
Diff-only snapshot of the 0.3.0 regen for review. The change actually lands via caffeinelabs/skills-internal#287 (x re-homed into skills-internal); this repo is being retired. Close without merging.
ggreif
marked this pull request as draft
September 11, 2026 09:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review artifact — will be closed without merging.
Shows the
0.2.5 → 0.3.0diff for the generatedx-clientso it can be reviewed as a diff. The change actually lands via caffeinelabs/skills-internal#287, which re-homes x intoskills-internal/packages/connectors/xand retires this standalone repo.What changed (0.3.0)
is_replicated = ?falsedefault — X is side-effecting; a replicated outcall duplicates the write and fails IC consensus.Any) body fix —createAccountActivitySubscriptionnow takesbody : Candid.Candid(was an unserialisableAny→ emptycandidValue).skills/tweeting-fine-points.md§3 rewritten to "non-replicated by default".Typechecks 597/597 in the new home. Do not merge — this repo will be deleted once 0.3.0 is confirmed published from skills-internal.