Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated names passed to
Newcurrently add duplicate hashes even though membership is stored by name. Removing that member leaves stale hashes and can panic during partition redistribution. Ignore existing members in the internal insertion path, asAddalready does.Also clear the load distribution when the last member is removed; otherwise
LoadDistributioncontinues reporting a departed member after the ring becomes empty.Both regressions fail before the fix. Full
go test -race -cover ./...passes (96.2% coverage), along withgo vet ./.... Tests cover partition ownership after duplicate removal and removal/repopulation of the final member.