Use arbitrary root during init - #474
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
=======================================
Coverage 88.54% 88.55%
=======================================
Files 27 27
Lines 1318 1319 +1
=======================================
+ Hits 1167 1168 +1
Misses 151 151 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adamltyson
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
Currently,
brainrenderhardcodes a structure named "root" to use as the root mesh. This may lead to errors if an atlas exists but doesn't call the root node "root".What does this PR do?
Generalise the current code by using the id of the root node of the atlas hierarchy to fetch an arbitrarily named root mesh to initialise the scene.
How has this PR been tested?
All tests pass, and examples checked by visual inspection.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: