Disable the use of [[msvc::no_unique_address]] on versions prior to 1943… - #557
Closed
pdimov wants to merge 1 commit into
Closed
Disable the use of [[msvc::no_unique_address]] on versions prior to 1943…#557pdimov wants to merge 1 commit into
pdimov wants to merge 1 commit into
Conversation
…943, because it causes a warning in C++14 and C++17 mode. Refs #499.
Member
Author
|
On second thought, updating msvc-14.3 silently changing the layout of classes using BOOST_ATTRIBUTE_NO_UNIQUE_ADDRESS might be problematic. We do this for different compiler versions (which is why we mangle the toolset name into the library name), but doing it within the same compiler version might be a bit too much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…, because it causes a warning in C++14 and C++17 mode. Refs #499.