Skip to content

fix(policy): warn on legacy 'retry' on_status_contradiction mode - #814

Draft
gmoncor wants to merge 1 commit into
bmad-code-org:mainfrom
gmoncor:fix/s01-14-warn-legacy-retry-on-status-contradiction
Draft

gmoncor wants to merge 1 commit into
bmad-code-org:mainfrom
gmoncor:fix/s01-14-warn-legacy-retry-on-status-contradiction

Conversation

@gmoncor

@gmoncor gmoncor commented Sep 17, 2026

Copy link
Copy Markdown

What: Pin a retirement target for the legacy retry value of review.on_status_contradiction and emit a load-time warning when it is selected.

Why: The option is already labeled "legacy" in its own description since #334 introduced escalate as the default, but has no version/issue owning its removal, and nothing warns an operator who is still using it. Related to #334 (closed), which established escalate as the default and demoted retry.

How:

  • Add a target version/issue reference to the core.toml description and the ReviewPolicy docstring.
  • Warn via warnings.warn(...) when on_status_contradiction == "retry" loads, mirroring the _fold_deprecated_engine pattern; the escalate default stays silent.
  • Add a pytest.warns test for the retry case and a negative test confirming escalate triggers no warning.

Testing: uv run pytest -q tests/test_policy.py.

Changelog: Changed: bmad-loop now warns when the legacy review.on_status_contradiction = "retry" mode is configured.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant