Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Emit an explicit warning when a configured
scm.max_parallel > 1is clamped to 1, instead of silently discarding the operator's intent.Why: Phase 5 parallel fan-out is not built yet (tracked in #229), so the knob is inert — but nothing today tells an operator who sets
max_parallel = 4that their setting has no effect, which reads as the loop mysteriously running slower than configured. Related to #229, which this PR does not implement.How:
loads(), warn viawarnings.warn(...)whenrequested_parallel > 1, mirroring the existing_fold_deprecated_enginewarning pattern.min(requested_parallel, 1)).pytest.warnstest asserting the warning fires formax_parallel > 1and that the resulting policy still clamps to 1.Testing:
uv run pytest -q tests/test_policy.py.Changelog:
Changed: bmad-loop now warns when scm.max_parallel > 1 is configured, since parallel fan-out is not yet built and the value is clamped to 1.🤖 Generated with Claude Code