Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Duplicate the
CANONICAL_EVENTSset fromadapters/profile.pyinto the stdlib-only hook script and itsevents.pytwin, and emit a non-blocking warning whenevent_namefalls outside that set.Why
Profile-parse time already enforces this whitelist before a hook is ever registered; this closes the defense-in-depth gap with a drift-detection warning, matching the existing never-fail treatment used for
hooks.relay-stale.How
CANONICAL_EVENTSinline inbmad_loop_hook.pyandevents.py(twin pattern, both stdlib-only, cannot import each other).event_nameis outside the set, still write the event exactly as today, but also emit a non-blocking warning (stderr, never stdout).tests/test_hook_script.pyandtests/test_events.py.Testing
Ran
tests/test_hook_script.pyandtests/test_events.py(45 passed, 9 skipped platform-specific); confirmed the twin-source parity check still passes with the duplicated set in both files.Changelog
Added: the hook script now warns (non-blocking) if it receives an event name outside the canonical set, without ever dropping the signal.
🤖 Generated with Claude Code