Skip to content

core: frontend: system-information: NetworkCard: Fix cropped text - #4451

Merged
patrickelectric merged 1 commit into
bluerobotics:masterfrom
patrickelectric:network-improvements
Sep 14, 2026
Merged

core: frontend: system-information: NetworkCard: Fix cropped text#4451
patrickelectric merged 1 commit into
bluerobotics:masterfrom
patrickelectric:network-improvements

Conversation

@patrickelectric

@patrickelectric patrickelectric commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fix #4450

New:
image

@patrickelectric
core: frontend: system-information: NetworkCard: Fix cropped text
b05fd2e 
Vuetify sizes subtitles as flex: 1 1 100%, so a label and its value
sharing a row both shrink to half of it and get cut by the ellipsis.

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
patrickelectric requested a review from a team September 14, 2026 19:18
@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

Automated PR Review

0. Summary

  • Verdict: LGTM :shipit:

Adds a scoped <style> block to core/frontend/src/components/system-information/NetworkCard.vue that overrides Vuetify's default flex: 1 1 100% on v-list-item__subtitle so label/value pairs size to their text and wrap to a new line instead of being ellipsised. The inline comment correctly explains the why (Vuetify's flex default), which matches AGENTS.md's guidance on comment quality. No behavioral, security, or dependency impact; targets Vuetify's public class hooks which receive the component's scoping attribute on child-root elements, so the scoped selectors are effective.

No further comments, nice job 👍

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.

@patrickelectric
patrickelectric merged commit 5ec5e9c into bluerobotics:master Sep 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoschmdt nicoschmdt nicoschmdt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

System-Information: Network tab has cropped text

2 participants

@patrickelectric @nicoschmdt