Skip to content

Frontend: update BlueBoat Power Module name and specs - #4444

Merged
joaoantoniocardoso merged 1 commit into
bluerobotics:masterfrom
Williangalvani:power_module_update_again
Sep 14, 2026
Merged

joaoantoniocardoso merged 1 commit into
bluerobotics:masterfrom
Williangalvani:power_module_update_again

Conversation

@Williangalvani

@Williangalvani Williangalvani commented Sep 14, 2026

Copy link
Copy Markdown
Member

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

Automated PR Review

0. Summary

  • Verdict: MINOR SUGGESTIONS ✏️

Renames two "BlueBoat120 Power Module" preset entries in SENSOR_PRESETS and updates one "Navigator w/ Blue Robotics Power Sense Module" preset in core/frontend/src/components/vehiclesetup/configuration/power/BatteryCard.vue, with a couple of tweaks to voltMult / ampOffset. Values are sourced from the Google Sheet linked in the PR body — I could not verify them independently, so this review is confined to code-level concerns.

6. Code Quality & Style

  • 6.1 [minor] core/frontend/src/components/vehiclesetup/configuration/power/BatteryCard.vue:372ampOffset: 1.64 breaks the 3-decimal convention used by every other Blue-Robotics-style entry in this table (0.330, 1.638, 1.638 previously). If the underlying spec is truly 1.64, prefer 1.640 for visual consistency with the surrounding entries; otherwise this looks like an accidental precision loss during the copy from the spreadsheet.

8. Documentation

  • 8.1 [minor] PR title/scope — the title says "update BlueBoat Power Module name and specs", but the diff also renames and re-tunes the third entry ('Navigator w/ Blue Robotics Power Sense Module''Navigator w/ Blue Robotics Power Module', voltMult 11.000 → 16.6809). That is not a BlueBoat change and is a much larger spec shift (≈1.52×) than the BlueBoat tweaks. Consider expanding the title to reflect the Navigator preset update, or splitting it into a separate commit/PR so git blame/git bisect on that voltage-multiplier change is easier to find later.

9. Nitpicks / Optional

  • 9.1 [nit] core/frontend/src/components/vehiclesetup/configuration/power/BatteryCard.vue:359-382 — after this PR the list contains three "Navigator w/ Blue Robotics …" entries plus a bare 'Blue Robotics Power Sense Module'. Item 4 (voltPin: 2, currPin: 3, non-Navigator) and item 5 (voltPin: 5, currPin: 4, Navigator) share identical voltMult/ampPerVolt/ampOffset, so users are picking purely on pin mapping via the label. Consider making the pin distinction explicit in the labels (e.g. suffixing the non-Navigator entry with "(Pixhawk pins 2/3)") to reduce mis-selection risk on the vehicle-setup page.
  • 9.2 [nit] The move-to-stable label is applied. Existing users who previously selected the old preset name in the UI will silently no longer match a labelled preset (the on-vehicle parameters are unchanged, but the dropdown will pick whichever entry now matches by values). Worth calling out in release notes so support isn't surprised.

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.

@Williangalvani
Williangalvani marked this pull request as draft September 14, 2026 16:22
@joaoantoniocardoso joaoantoniocardoso added the move-to-stable Needs to be cherry-picked and move to stable label Sep 14, 2026
@Williangalvani
Williangalvani force-pushed the power_module_update_again branch from 814f2c3 to 2679d5f Compare September 14, 2026 18:24
Replace the BlueBoat-named entries with the current Blue Robotics calibrations so Power Sense Module/PowerSwitch R2, PowerSwitch R1, and Power Module are all selectable.
@Williangalvani
Williangalvani marked this pull request as ready for review September 14, 2026 21:30
@Williangalvani
Williangalvani requested a review from a team September 14, 2026 21:47
@joaoantoniocardoso
joaoantoniocardoso merged commit 1f7dd7a into bluerobotics:master Sep 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

move-to-stable Needs to be cherry-picked and move to stable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants