Skip to content

fix(desktop): preserve remote agent identity and mention routing - #7114

Draft
loganj wants to merge 1 commit into
mainfrom
reconcile/mention-profile-forum-nip-oa-3ba1b88c
Draft

fix(desktop): preserve remote agent identity and mention routing#7114
loganj wants to merge 1 commit into
mainfrom
reconcile/mention-profile-forum-nip-oa-3ba1b88c

Conversation

@loganj

@loganj loganj commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

🤖

Summary

Using an owned agent from another device in Buzz Desktop exposed several disconnected problems: the agent could be missing from discovery, a mention could lose its selected identity, a historical author could open a different agent's profile, and a deployment record could look like online presence. The combined candidate aimed to let you find and contact the existing agent from another device while showing the correct profile, controls and connection status.

The work has been split into eight replacement PRs. This original draft is retained for source and historical evidence, not as the active combined landing candidate. Neither this PR nor the replacement set is claimed complete, merged, installed or deployed.

Related issue

Replacement PRs and dependencies:

Replacement User-visible change Stack
#7128 Type immediately after a multi-word mention without losing its separator; respect deliberate caret movement main#7128#7133
#7133 Distinguish same-name selections and show ambiguity rather than guess a recipient Parent #7128; reference-fallback corrections remain open
#7131 Open the clicked agent, not another agent sharing its definition or controls Independent on main
#7127 Show availability from presence, separately from lifecycle actions Independent on main
#7129 Use one “Not managed on this device” marker across identity surfaces Independent on main
#7122 Find an agent you own without managing it on this device or sharing a channel main#7122#7124#7125
#7124 Invite a remote agent and check the actual destination without silently dropping the selected recipient Parent #7122; includes the later deliberate-deletion recovery correction
#7125 Add Invite/Cancel to standalone forum composition using the same authorization contract Parent #7124; includes its source-draft recovery correction

Each replacement describes its own scope and current evidence. Discovery does not add membership; a cloud marker does not mean online; accepted membership does not guarantee a response. The routing stack alone does not include the separate spacing/duplicate-name fixes.

Testing

This is historical source at 98fe33ecaf43b47bd3530de6517c15722d2be895, not evidence for the later replacement heads. The original remote integration run failed, including presence-fixture and ambiguous-onboarding cases. The replacement PRs document their own behavior and test scope.

Original screenshot set and captions show simulated hover/profile/direct-message cloud-marker UI at the retained source head. They are historical visuals, not current replacement or live remote-agent evidence. No before-image was captured.

Historical validation and related work

The original candidate reported full local just ci on its overlay at base 3ed623bb217bf9697b0ce4562529254977e0ea04: 5,830 desktop frontend tests, 3,117 native tests (19 ignored), 2,007 mobile tests, static checks and builds. Selected browser coverage was 130 regressions plus 3 profile cases, not the entire browser suite. These results do not supersede the failed remote run or the recipient-reference and draft-recovery limitations documented in the replacement PRs. No installed-native/two-device delivery, agent responsiveness or termination guarantee was established.

Related work: preserved merged #6956; overlapping #6882 (direct-message discovery), #6883 (adding an existing agent), #6284 (owner exemption) and #5484 (missing-policy behavior, not included). The sibling redirect in #6077 and deployment-based availability in #7078 differ from this work's exact-identity and connection-presence behavior. No related PR is closed or merged by this description pass.

Originating Buzz discussion · channel f7a9536a-1738-4bad-a888-b3ea25010ef1.

Discover authenticated owned relay identities independently of local runtimes, keep preparation distinct from fresh destination authorization, and preserve exact selected recipients through invitations and edits.

Keep explicit profiles bound to their public key, use relay presence for availability, and show consistent cloud provenance without claiming hosting location. Include native signed-fixture and browser regression coverage.

Signed-off-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>

Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
Signed-off-by: Logan Johnson <loganj@squareup.com>
@loganj
loganj requested a review from a team as a code owner August 31, 2026 16:34
@github-actions

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is 3ed623bb217bf9697b0ce4562529254977e0ea04...98fe33ecaf43b47bd3530de6517c15722d2be895.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review 98fe33ecaf43b47bd3530de6517c15722d2be895 to authorize a new review.
Any previous review applies only to its recorded range.

@loganj

loganj commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

@buzz-security-review 98fe33e

@loganj

loganj commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

Remote-agent provenance — final candidate

Synthetic browser fixtures rendered from the exact candidate Desktop source at 98fe33ec; these establish UI presentation, not live agent availability. Each view asserts the cloud marker and its accessible label Not managed on this device. No before-image is claimed.

Hover card

Remote Scout has the shared cloud marker beside the agent identity, without local runtime controls.

remote-cloud-hover

Exact-key profile

The same relay identity and cloud marker; a same-persona local sibling does not replace this profile.

remote-cloud-profile

DM header and sidebar

The marker appears in both the selected DM row and its header; the grey presence dot remains independent.

remote-cloud-dm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant